Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stretch #4

Closed
hecrj opened this issue Sep 5, 2019 · 1 comment · Fixed by #52
Closed

Upgrade stretch #4

hecrj opened this issue Sep 5, 2019 · 1 comment · Fixed by #52
Labels
feature New feature or request help wanted Extra attention is needed improvement An internal improvement question Further information is requested

Comments

@hecrj
Copy link
Member

hecrj commented Sep 5, 2019

Iced was built during May using the 0.2 version of stretch. It seems that a new minor version was released recently, in July. We should consider upgrading.

At a first glance, the API has changed somewhat considerably. There is a new Stretch type that you have to keep around and mutate accordingly. I am guessing this allows (or will allow) for incremental computation of layouting, which is great!

However, in order to mutate the Stretch type and keep it in sync, we will need to implement a diffing strategy of nodes. This is mostly a solved problem, as React and Elm already do it, but some research will certainly be necessary and we will probably need to change the API a bit.

Also, as a naive first approach, we could simply recreate the Stretch type entirely every time.

In any case, benchmarking before upgrading is a good idea.

@hecrj hecrj added feature New feature or request help wanted Extra attention is needed improvement An internal improvement question Further information is requested labels Sep 5, 2019
@msiglreith
Copy link

As I'm probably to blame for this new API, it was mostly motivated by reusing memory and nodes across changes. The author seems to be interested in more incremental relayouting possibly in combination with salsa but that's currently beyond me!

Issues, performance numbers and general feedback appreciated!

@hecrj hecrj closed this as completed in #52 Nov 14, 2019
hecrj pushed a commit that referenced this issue Oct 29, 2022
CurryPseudo pushed a commit to CurryPseudo/iced that referenced this issue Apr 25, 2023
set ime cadidate window position when clicked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed improvement An internal improvement question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants