Address Clippy lints #1379
Merged
Address Clippy lints #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and explicitly annotate crates as well.
... and check those in CI as well!
hecrj
approved these changes
Jul 9, 2022
There was a problem hiding this comment.
Awesome! Thank you 🥳 Lots of needless borrows I see!
I have gone ahead and fixed all of the reasonable lints in all of the crates and disabled the unreasonable ones.
Additionally, I have introduced a new lint workflow on GitHub CI that should error if we ever make clippy angry. Let's see how this pans out!
|
Thanks, I was not sure which choices were intentional and which ones should be fixed, that's why my PR was fixing only some of them, so it's great that you did all the remaining ones that I was not sure about. 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of stylistic changes based on Clippy lints