feat: Additional actions for window controls #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
reviewed
Oct 11, 2022
Exposes access to the winit window's window_drag method as an action.
mmstick
force-pushed
the
cosmic-window-controls
branch
from
72fc5c9 to
176bcab
Compare
mmstick
force-pushed
the
cosmic-window-controls
branch
from
176bcab to
ac6e137
Compare
hecrj
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new window actions to enable the possibility to create client-side decorations in Iced applications. libcosmic has a functioning headerbar widget which utilizes these actions and their functions. We could add a headerbar widget example for demonstrating the functionality.
Action::DragAction::Maximize(bool)Action::Minimize(bool)Action::ResizeDragAction::ToggleMaximizeResizeDragis currently a no-op because it requires a patch to winit. I am working on this patch at the moment.Partially implements #759
Related RFC: iced-rs/rfcs#13