Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't convert svg to BGRA before passing to shader #1507

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Don't convert svg to BGRA before passing to shader #1507

merged 1 commit into from
Nov 5, 2022

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Nov 5, 2022

Now that the shader is using RGBA, this incorrectly swaps the components.

@ids1024
Don't convert svg to BGRA before passing to shader
a250aab 
Now that the shader is using RGBA, this incorrectly swaps the
components.
hecrj
hecrj approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Good catch.

@hecrj hecrj added bug Something isn't working rendering image labels Nov 5, 2022
@hecrj hecrj added this to the 0.5.0 milestone Nov 5, 2022
@hecrj hecrj merged commit da2325d into iced-rs:master Nov 5, 2022
@hecrj hecrj mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working image rendering
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ids1024 @hecrj