Add support for setting window icon #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Apr 27, 2020
winit/src/settings.rs
Outdated
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct Icon { | ||
| /// | ||
| rgba: Box<[u8]>, |
frapa
force-pushed
the
add_support_for_window_icons
branch
from
c21d298 to
b9fdfb8
Compare
|
@hecrj Do you mean that no code should be added to the main iced package? As far as I can see, the web package is very experimental, but I could try implementing the favicon there, too. I don't really get the build process, tough... |
This adds a new property from Settings::window::iconand a Icon struct which can be converted to winit::window::Icon. It also adds code to display this icon in Application::run. Due to the fact that the Icon struct is non copyable, I also had to remove the Copy trait from all Settings, both in `iced` and `iced_winit`.
hecrj
force-pushed
the
add_support_for_window_icons
branch
from
b9fdfb8 to
9a037a2
Compare
hecrj
changed the title
hecrj
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
I have moved the Icon type to the iced crate to properly hide the iced_winit dependency and avoid breaking the Wasm target.
Additionally, I have changed Icon::from_rgba to return a proper error instead. We avoid panicking in a From trait this way.
I believe this is ready to be merged. Let me know what you think!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to start the discussion around this topic, the code is currently a hack, the naming is not final and I just added it somewhere, not even in the right place. But since this is my first contribution to the library and my experience with Rust is not extensive, I would like if somebody more experienced can have a look an tell me if I'm on the right track.
This adds a new property from
Settings::window::iconand anIconstruct which can be converted towinit::window::Icon.It also adds code to display this icon in
Application::run.Due to the fact that the Icon struct cannot be copied, I had to remove the Copy trait from all Settings,
both in
icedandiced_winit. This is an API breaking change.Currently, I'm able to set an icon with the code:
Thanks to
winitit gets correctly displayed also on the taskbar:And of course in the window switcher (alt+tab).
Fixes #433.