Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Text widget Clone even if the Renderer isn't #363

Merged
merged 1 commit into from
May 29, 2020
Merged

Make the Text widget Clone even if the Renderer isn't #363

merged 1 commit into from
May 29, 2020

Conversation

Imberflur
Copy link
Contributor

No description provided.

hecrj
hecrj requested changes May 27, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.

Just a small nitpick!

native/src/widget/text.rs Outdated Show resolved Hide resolved
@hecrj hecrj added the improvement An internal improvement label May 27, 2020
@hecrj hecrj added this to the 0.2.0 milestone May 27, 2020
hecrj
hecrj approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you!

@hecrj hecrj merged commit 01a4d65 into iced-rs:master May 29, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Imberflur @hecrj