Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculated sweep_angle in call to lyon::geom::Arc was actually end_angle #401

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Calculated sweep_angle in call to lyon::geom::Arc was actually end_angle #401

merged 1 commit into from
Jun 11, 2020

Conversation

Vanille-N
Copy link
Contributor

@Vanille-N Vanille-N commented Jun 11, 2020 •
edited by hecrj
Loading

Fixes #400.

All tests pass, all other (2) uses of end_angle are correct.

@Vanille-N
Calculated sweep_angle in call to lyon::geom::Arc was actually end_angle
7b6f1ba 
Adresses `Arc end_angle should be renamed to span_angle #400`
hecrj
hecrj approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hecrj hecrj added the bug Something isn't working label Jun 11, 2020
@hecrj hecrj added this to the 0.2.0 milestone Jun 11, 2020
@hecrj hecrj merged commit 2a516df into iced-rs:master Jun 11, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Arc end_angle should be renamed to span_angle
2 participants
@Vanille-N @hecrj