Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement From<Color> for Option<Background> #487

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Implement From<Color> for Option<Background> #487

merged 2 commits into from
Aug 25, 2020

Conversation

Kaiden42
Copy link
Contributor

@Kaiden42 Kaiden42 commented Aug 18, 2020 •
edited by hecrj
Loading

This PR implements the feature requested by #473.

I've also updated the styling example fitting the new feature.

Closes #473.

@hecrj hecrj added the improvement An internal improvement label Aug 25, 2020
@hecrj hecrj added this to the 0.2.0 milestone Aug 25, 2020
hecrj
hecrj approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you! 🎉

@hecrj hecrj merged commit 56273c5 into iced-rs:master Aug 25, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Implement From<Color> for Option<Background>
2 participants
@Kaiden42 @hecrj