Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade tokio to latest version(v0.3) #595

Merged
merged 3 commits into from
Nov 25, 2020
Merged

upgrade tokio to latest version(v0.3) #595

merged 3 commits into from
Nov 25, 2020

Conversation

valbendan
Copy link
Contributor

No description provided.

hecrj
hecrj requested changes Nov 6, 2020
View reviewed changes
src/executor.rs Outdated Show resolved Hide resolved
@valbendan @hecrj
Update src/executor.rs
a4ad1b2 
fix executor other than tokio

Co-authored-by: Héctor Ramón <hector0193@gmail.com>
@hecrj hecrj added the improvement An internal improvement label Nov 6, 2020
@hecrj hecrj added this to the 0.2.0 milestone Nov 6, 2020
@hecrj
Copy link
Member

hecrj commented Nov 9, 2020 •
edited
Loading

Before merging, I think it may be better to wait a bit until most of the async ecosystem upgrades to the latest tokio release.

A bunch of examples are using reqwest, which has not been upgraded yet: seanmonstar/reqwest#1076. This causes duplicated dependencies and panics.

@clarkmoody
Copy link
Contributor

Tested locally, and this works for the Game of Life and Solar System example programs.

@hecrj
Copy link
Member

hecrj commented Nov 9, 2020 •
edited
Loading

As I mentioned, reqwest has not yet migrated, so examples like pokedex and download_progress do not work.

We could use the compatibility layer, but it's probably better to wait for a bit.

@hecrj hecrj mentioned this pull request Nov 10, 2020
Merged
@hecrj
Introduce tokio_old feature
782dd2f 
This feature allows users to rely on the `0.2` version of `tokio` while
the async ecosystem upgrades to the latest version.
hecrj
hecrj approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have introduced a new tokio_old feature flag to allow users to enable the old tokio and transition once the ecosystem is ready.

I think we can merge this. Let me know what you think!

@valbendan
Copy link
Contributor Author

I think we can merge it

@hecrj
Copy link
Member

hecrj commented Nov 25, 2020 •
edited
Loading

I have rolled back the latest changes to .gitignore.

We should try to keep the repository decoupled from specific dev environments. For that purpose, you should change the .git/info/exclude file instead.

@valbendan
Copy link
Contributor Author

It seems I forget checkout a new branch, sorry for the inconvenient

@hecrj hecrj merged commit 87c9df2 into iced-rs:master Nov 25, 2020
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@valbendan @hecrj @clarkmoody