Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculating of units diff #18

Open
Tetraquark opened this issue Jul 21, 2020 · 0 comments
Open

Wrong calculating of units diff #18

Tetraquark opened this issue Jul 21, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Tetraquark
Copy link
Collaborator

It looks like sometimes the diff calculation does not work correctly after updating the unit list. A prime example is adding the end of the list the loading unit to display the loading process of the next page of the list. After deleting the loading unit then for all units will be called binding again.

Maybe we can add a callback to calculate the diff or to specify the correct identifier or hash of the unit data outside (or pass a comparator or something).

@Tetraquark Tetraquark added the bug Something isn't working label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant