Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Quic keep alive option to enable keep alive #3353

Closed
bentoi opened this issue Jun 13, 2023 · 3 comments · Fixed by #3991
Closed

Missing Quic keep alive option to enable keep alive #3353

bentoi opened this issue Jun 13, 2023 · 3 comments · Fixed by #3991
Labels
Milestone

Comments

@bentoi
Copy link
Contributor

bentoi commented Jun 13, 2023

There's no option to enable keep alive on a Quic connection. As a consequence the Quic connection might idle timeout if there's no activity and even if an icerpc request is pending. This is quite bad IMO.

Should we consider adding a workaround to keep alive the Quic connection? One option would be to open an unidirectional stream to send a byte regularly (implemented in the Quic transport).

See also dotnet/runtime#87478. Hopefully this will motivate the Quic developers for adding this option.

@bentoi bentoi added the quic label Jun 13, 2023
@bentoi bentoi added this to the 0.2 milestone Jun 13, 2023
@bernardnormier bernardnormier modified the milestones: Future, 0.2.0 Sep 19, 2023
@bernardnormier
Copy link
Member

See also: microsoft/msquic#3880

@bernardnormier bernardnormier modified the milestones: 0.2.0, Future Nov 15, 2023
@bentoi
Copy link
Contributor Author

bentoi commented Dec 27, 2023

FYI, they added KeepAliveInterval which I believe can be used for this purpose: dotnet/runtime#94211

@bernardnormier bernardnormier modified the milestones: Future, 0.3.0 Jan 25, 2024
@bernardnormier
Copy link
Member

Let's update the code conditionally (and add a test) once dotnet 9 preview 1 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants