-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix line endings #3862
Comments
This affects the bash scripts included with IceRpc.Protobuf.Tools NuGet package, because we build the packages on a Windows VM.
|
pepone
added a commit
that referenced
this issue
Dec 12, 2023
- Set default to LF line endings for all text files - Define CRLF line endings for .bat and .ps1 files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should fix all text files to use LF line endings as per:
https://code.visualstudio.com/docs/remote/troubleshooting#_resolving-git-line-ending-issues-in-wsl-resulting-in-many-modified-files
With the current settings, line endings are converted to the platform default on checkout, which causes problems with Visual Studio Code dev containers. If you try to open a local clone on a dev container the bash script used for building will not work because the extra
\r
The text was updated successfully, but these errors were encountered: