Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute if Protobuf files need to be rebuilt #3852

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

pepone
Copy link
Member

@pepone pepone commented Dec 6, 2023

Fixes #3841

Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

public class ProtocTask : ToolTask
{
/// <summary>The output directory for the generated code; corresponds to the <c>--icerpc-csharp_out=</c> option of the
/// <c>protoc</c> compiler.</summary>
/// <summary>Gets or set the output directory for the generated code; corresponds to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets or set_s_ (same below)

Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pepone pepone merged commit da2d7a0 into icerpc:0.2.x Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants