Update release workflow to build the reporter before packaging tools #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Sep 16, 2024
| env: | ||
| SLICEC_CS_STAGING_PATH: ${{ github.workspace }}\tools\slicec-cs\staging | ||
| - name: Build IceRPC | ||
| run: dotnet build --configuration Release --output . |
There was a problem hiding this comment.
We need to build IceRpc solution before creating the tool packages, otherwise the reporters would be missing in the tools packages.
bernardnormier
approved these changes
Sep 16, 2024
build.sh
Outdated
| @@ -89,7 +89,7 @@ publish() | |||
| global_packages=$(dotnet nuget locals -l global-packages) | |||
| global_packages=${global_packages/global-packages: /""} | |||
| run_command rm "-rf" "$global_packages/zeroc.slice/$version" "$global_packages/icerpc/$version" "$global_packages"/icerpc.*/"$version" | |||
| run_command dotnet "nuget" "push" "tools/**/$dotnet_config/*.$version.nupkg" "--source" "$global_packages" | |||
| run_command dotnet "nuget" "push" "tools/**/$dotnet_config/*.$version*.nupkg" "--source" "$global_packages" | |||
There was a problem hiding this comment.
Is * missing from the line below, in case we update some src packages, like for example IceRpc.Templates?
There was a problem hiding this comment.
Windows script doesn't handle this versions well, need to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4079