Improve Slic slow write test #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Nov 15, 2024
externl
approved these changes
Nov 15, 2024
pepone
pushed a commit
to pepone/icerpc-csharp
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small update to Slic's Connection_with_idle_timeout_and_slow_write_is_not_aborted test, in an effort to figure out #4108.
Note that the 500ms duration chosen by this test happens to match Slic's read timer:
icerpc-csharp/src/IceRpc/Transports/Slic/Internal/SlicDuplexConnectionDecorator.cs
Line 119 in bcec78b
So, with the test as written, the test sends a (one-way) byte every 500ms and Slic sends a Ping frame every 500ms (to get back a Pong frame). Assuming a little latency, this 1-byte write should be written first in subsequent iterations since Slic resets its read timer when it reads the Pong frame. It's not clear if we chose 500ms to match the Slic read timer or if it's accidental.