Skip to content
This repository has been archived by the owner on Jun 22, 2023. It is now read-only.

blackbench needs more code to run Black against #1

Open
ichard26 opened this issue Jun 14, 2021 · 1 comment
Open

blackbench needs more code to run Black against #1

ichard26 opened this issue Jun 14, 2021 · 1 comment

Comments

@ichard26
Copy link
Owner

ichard26 commented Jun 14, 2021

At the moment of writing doesn't come with much benchmark data to run black against. It's basically a 21.6b0 checkout of black's source code + one string micro target (based off of Jelle's discovery of ESP causing slowdowns). I'd appreciate more code files to throw to black.

I'm looking for two kinds of targets: "normal" and "micro" . Normal targets should represent real-world code (so the benchmarking data actually represents real-world performance). Micro targets should be small and are focused on one area of black formatting (and mostly exist to measure performance in a specific area, like string processing).

In terms of hard rules: normal targets shouldn't be bigger than ~2000 lines (this is to keep time requirements to run the benchmark based off the target managable), and micro targets shouldn't be bigger than ~400 lines.

Thank you in advance!

@ichard26 ichard26 added the help wanted Extra attention is needed label Jun 14, 2021
@ichard26 ichard26 pinned this issue Jun 14, 2021
@ichard26 ichard26 unpinned this issue Jul 27, 2021
@ichard26
Copy link
Owner Author

With the release of 21.7.dev2, this has been mostly addressed. I'm sure the included targets could use some more tweaking but this doesn't need to be pinned anymore :)

@ichard26 ichard26 removed the help wanted Extra attention is needed label Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant