This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
LZ4 support #109
Merged
LZ4 support #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| begin | ||
| require 'lz4-ruby' | ||
| rescue LoadError => e | ||
| raise LoadError, %[Snappy support requires the "lz4-ruby" gem: #{e.message}], e.backtrace |
There was a problem hiding this comment.
This should probably read LZ4 support... 😄
Broken because lz4-ruby doesn't handle multi-byte characters
This one supports multibyte characters
[ci skip]
It's not a big optimization, but it's something
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since komiya-atsushi/lz4-ruby#3 and komiya-atsushi/lz4-ruby#7 are now fixed, and v0.3.2 is out, cql-rb can finally get LZ4 support.
Turns out that Cassandra also uses a non-standard LZ4 format, the encoded data is prefixed with an int with the uncompressed size. Very convenient, but also completely undocumented as far as I can tell.