This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Fixing varint and decimal encoding/decoding #118
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found several numbers which were encoding/decoding incorrectly. The issue was in append_varint.
Example:
append_varint(1042342234234); read_varint
returns-57169393542
Also made a small change to read_decimal which would occasionally fail to decode decimals between -1 and 0.
Example:
append_decimal(-0.031108612692221094); read_decimal
returns0.0