Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated publishing of new tzdb versions #2

Open
N-Coder opened this issue May 19, 2021 · 0 comments
Open

Automated publishing of new tzdb versions #2

N-Coder opened this issue May 19, 2021 · 0 comments

Comments

@N-Coder
Copy link
Member

N-Coder commented May 19, 2021

We should use a scheduled CI workflow that regularly (e.g. weekly) checks for a new version of the tzdb and automatically publishes a new version to pypy if there is one. This needs some minor changes to the update.py script to automatically pick up the version of the downloaded tzdb data files. Furthermore update_zoneinfo.py curently uses an unreleased ics.py version to parse the vTimezones, check whether there are any non-trivial changes, and only copy them with their new IDs if that is the case. As this requires ics.py v0.8, which in turn might depend on this project, we kind of have a cyclic dependency - which is easy to solve when running manually, but might force the automated workflow to be deferred until after 0.8 is out.

Side node: publishing to PyPy could allow introducing arbitrary code, which would then be delivered to and executed by anyone who uses this library, so special care needs to be taken to not introduce any possibilities for an attack, e.g. by only publishing changes from the master branch (compare ics.py#274).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant