Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coupling parameters for Hand MK5.1 #307

Closed
xEnVrE opened this issue Sep 11, 2023 · 4 comments · Fixed by #312
Closed

Update coupling parameters for Hand MK5.1 #307

xEnVrE opened this issue Sep 11, 2023 · 4 comments · Fixed by #312
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@xEnVrE
Copy link
Contributor

xEnVrE commented Sep 11, 2023

Today, while reviewing the newly opened PR icub-tech-iit/ergocub-software#169, I had the chance to compare the documented parameters of the coupling law for the MK5 .1 hand and a table that can be found in https://github.com/icub-tech-iit/ergocub-design-lowerarm/issues/157#issuecomment-1674984233.

It seems that there are discrepancies for the following paremeters.

Note: green and yellow highlighed text is just coming from the screenshot of the "table" indicated above. I am not highlighting anything.

Moreover please take into account that for each "table" entry the order of numbers is "thumb", "index" and "pinky" (as index == middle == ring) while each "documentation" entry report all the 5 parameters in the order "thumb", "index", "middle", "ring", "pinky".

Parameter $q_{0off}$

table

image

documentation

image

Parameter $k$

table

image

documentation

image

Parameter $d$

table

image

documentation

image

Parameter $l$

table

image

documentation

image

Parameter $b$

table

image

documentation

image

Parameter $s$

table

image

documentation

image

Parameter $t$

table

image

documentation

image

Parameter $f$

table

image

documentation

image

Paramter $r$

table

image

documentation

image

cc @pattacini

@pattacini
Copy link
Member

cc @fiorisi @Lawproto

@pattacini pattacini added the documentation Improvements or additions to documentation label Sep 12, 2023
@Lawproto
Copy link
Member

Lawproto commented Sep 12, 2023

@xEnVrE a small disclaimer. The excel file only served me to update the documentation, it should not be considered official. The values you screenshotted were reported to me from @ale-git as a double-check, are in m instead of mm and I do not exactly know how they have been obtained when there is some difference with the one I measured via CAD (yellow highlight). In general, I considered the difference small enough and I put the value coming from the CAD inside the documentation.

However, I just noticed that for the single letter length parameters I accidentally copied the Mk5.0 parameters instead of putting the correct ones. I thank you for pointing this out, I will proceed with an update via PR.

@xEnVrE
Copy link
Contributor Author

xEnVrE commented Sep 12, 2023

Thanks for the clarification @Lawproto.

Indeed I though they were not super official but the parameters were the same as Mk 5.0, as you said, hence I though it was important to notify that as it seemed very strange to me.

Moreover while I was conducting experiments on Gazebo, in order to study the length of the fingers, I have also asked some numbers to @ale-git and they were very different from those of the documentation, hence I was kinda sure that something was wrong.

@Lawproto
Copy link
Member

PR opened.
#312

@pattacini pattacini linked a pull request Sep 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants