Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r_sole and l_sole are not centered #23

Closed
Nicogene opened this issue Jan 9, 2023 · 5 comments · Fixed by #27
Closed

r_sole and l_sole are not centered #23

Nicogene opened this issue Jan 9, 2023 · 5 comments · Fixed by #27
Assignees
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix

Comments

@Nicogene
Copy link
Member

Nicogene commented Jan 9, 2023

#22 added the unit tests that checks if l_sole and r_sole are parallel.

It gives the following error:

l_sole_y is 0.07435, while r_sole_y is -0.07445 while they should be simmetric (diff : 0.0001 )

sole_height and sole_x seems fine instead

cc @salvi-mattia @traversaro @mfussi66 @pattacini @Mick3Lozzo

@Nicogene Nicogene added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Jan 9, 2023
@salvi-mattia
Copy link
Member

in cad model they r parallel

immagine

and they are parallel in the SW mechanism

immagine

where does this misalignement came from??

@Nicogene
Copy link
Member Author

Nicogene commented Jan 9, 2023

I tried to compute from code the same transform as:

    iDynTree::Transform l_sole_H_r_sole = comp.getRelativeTransform(l_sole,r_sole);
    std::cerr<<"l_sole - r_sole "<<l_sole_H_r_sole.getPosition().toString()<<std::endl;

And I got:

l_sole - r_sole -5e-05 -0.1488 0

That is the same as the cad.

Since we are computing the alignment of the frames using the two transforms root_link_H_r_sole and root_link_H_l_sole, maybe the root_link frame is not perfectly centered?

cc @fiorisi @traversaro @Mick3Lozzo @salvi-mattia

@salvi-mattia
Copy link
Member

the two soles' CSYS are off center
@Mick3Lozzo is investigating

immagine

immagine

@Mick3Lozzo
Copy link
Member

Mick3Lozzo commented Jan 9, 2023

The problem is the placement of the upper body on the lower body, is merely a CAD assembling problem.

⬆️Between the bright green supports of the torso pitch motor and the dark green plate housing the torso yaw motor, there is a 0.1 mm gap which is necessary for assembling the components without interference problems due to the tolerance chain.

⬆️  This gap should be equally distributed between the left and right sides of the joint but is all on one side.

⬆️  This coincident constraint should have been offset 0.05 mm.

I have corrected the misalignment, and now the robot is fully symmetrical again ⬇️.

We must correct some shrinkwraps, probably the root link and the other links directly constrained to it.

@fiorisi @traversaro @mfussi66 @salvi-mattia @Nicogene

@Nicogene Nicogene changed the title r_sole and l_sole are not parallel r_sole and l_sole are not centered Jan 10, 2023
@Mick3Lozzo
Copy link
Member

Mick3Lozzo commented Jan 12, 2023

Corrected.

image

image

As a bonus, I resolved some other inconsistencies I found on the shoulders too.

We can re-generate the URDF again (until the next bug).

@fiorisi @traversaro @mfussi66 @salvi-mattia @Nicogene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants