Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check orientations of ft sensors in the arms #24

Closed
Nicogene opened this issue Jan 9, 2023 · 1 comment · Fixed by #22
Closed

Check orientations of ft sensors in the arms #24

Nicogene opened this issue Jan 9, 2023 · 1 comment · Fixed by #22
Assignees
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix

Comments

@Nicogene
Copy link
Member

Nicogene commented Jan 9, 2023

With #22 we added the unit test that checks the ft sensors orientation.
Using the root-ftSensor transformation used for icub3 makes the test fail:

ergocub-model-test : transform between root_link and l_arm_ft_sensor is not the expected one, test failed.
ergocub-model-test : Expected transform : -0.267012 -0.961047 0.0713662
-0.960459 0.271447 0.0619303
-0.0788901 -0.0520081 -0.995526

ergocub-model-test : Actual transform : -0.250563 -0.961047 0.116648
-0.935113 0.271447 0.227771
-0.250563 -0.0520081 -0.966702


ergocub-model-test : base_link test performed correctly 
ergocub-model-test : transform between root_link and r_arm_ft_sensor is not the expected one, test failed.
ergocub-model-test : Expected transform : -0.267012 0.961047 0.0713662
0.960459 0.271447 -0.0619303
-0.0788901 0.0520081 -0.995526

ergocub-model-test : Actual transform : -0.250563 0.961047 0.116648
0.935113 0.271447 -0.227771
-0.250563 0.0520081 -0.966702

If this discrepancy with icub3 is correct, we can ignore this issue and change the expected transformations in the unit tests reading them from the creo

cc @pattacini @traversaro @Mick3Lozzo @salvi-mattia @mfussi66

@Nicogene Nicogene added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Jan 9, 2023
@Nicogene Nicogene changed the title Check Ft sensors orientations Check orientations of ft sensors in the arms Jan 9, 2023
@pattacini pattacini linked a pull request Jan 10, 2023 that will close this issue
@Nicogene
Copy link
Member Author

Nicogene commented Jan 10, 2023

The discrepancy in the orientation is due to the fact that icub3 and ergocub mechanisms are saved with different joints configurations (shoulder_roll), then we can ignore this difference and make the test happy. (see #7 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant