Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests and CI #6

Closed
Nicogene opened this issue Dec 21, 2022 · 1 comment · Fixed by #22
Closed

Add unit tests and CI #6

Nicogene opened this issue Dec 21, 2022 · 1 comment · Fixed by #22
Assignees
@Nicogene
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix

Comments

@Nicogene
Copy link
Member

We need to enable the unit tests for checking the consistency of the urdf after each generation, like: https://github.com/robotology/icub-models-generator/tree/master/tests

Moreover we should add a CI job when opening a PR that runs those tests.
@pattacini pattacini added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Dec 21, 2022
@Nicogene Nicogene mentioned this issue Dec 27, 2022
Closed
@Nicogene Nicogene mentioned this issue Jan 9, 2023
Merged
@Nicogene
Copy link
Member Author

Nicogene commented Jan 9, 2023

#22 adds the PRs as triggers for running the model generation + test.

Only in case of push on the master branch in case of success of the CI a PR with the new urdf generated is produced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicogene Nicogene

Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable test for model generation icub-tech-iit/ergocub-software
2 participants
@pattacini @Nicogene