Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the old facial expressions with the new centered ones #114

Merged
merged 1 commit into from
May 16, 2023

Conversation

martinaxgloria
Copy link
Member

As per title.

Tests on ergoCub should be done in order to check the new position on the OLED.

@pattacini pattacini linked an issue May 15, 2023 that may be closed by this pull request
@martinaxgloria
Copy link
Member Author

Today I tried the new facial expressions on ergoCub and this is the results:

photo_5990164362469424288_y

Compared to the previous version (video below):

237138740-3f407843-ac58-4574-a0be-9b8d7a599486.mov

they seem to be more centered and also up enough.

cc @pattacini @Nicogene @maggia80

@pattacini
Copy link
Member

they seem to be more centered and also up enough.

Nice!
I think we got it.

@martinaxgloria martinaxgloria marked this pull request as ready for review May 16, 2023 08:22
@pattacini pattacini merged commit 9bba2f0 into icub-tech-iit:master May 16, 2023
@martinaxgloria martinaxgloria deleted the fix/expressions branch May 16, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test better-centered expressions
3 participants