Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing sdf version #15

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Fix missing sdf version #15

merged 1 commit into from
Dec 23, 2022

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene requested a review from traversaro December 23, 2022 15:15
@Nicogene Nicogene self-assigned this Dec 23, 2022
@traversaro
Copy link
Member

If you prefer we can we can just set the version to 1.7, all the machinery of expanding the version was there due to the need of supporting Gazebo (Classic) 9/SDF 1.6 (see robotology/icub-models#40, robotology/icub-models#39 and gazebosim/gazebo-classic#2728), that fortunatly we do not need anymore to support.

@Nicogene Nicogene merged commit 1189fa4 into master Dec 23, 2022
@Nicogene Nicogene deleted the addSDFversion branch December 23, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants