Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCubV1*: move down the l/r_sole frames #187

Merged
merged 5 commits into from
Nov 6, 2023
Merged

ergoCubV1*: move down the l/r_sole frames #187

merged 5 commits into from
Nov 6, 2023

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Nov 6, 2023

It fixes #186

I regenerated the urdf of the robots and added a unit test for checking the soles placements

cc @GiulioRomualdi

@Nicogene Nicogene self-assigned this Nov 6, 2023
@Nicogene Nicogene requested a review from traversaro November 6, 2023 13:49
@Nicogene Nicogene marked this pull request as ready for review November 6, 2023 13:49
@Nicogene Nicogene changed the title ergoCubV1_1: move down the l/r_sole frames ergoCubV1*: move down the l/r_sole frames Nov 6, 2023
@GiulioRomualdi
Copy link
Contributor

Thank you @Nicogene!

@Nicogene Nicogene merged commit f7ba46b into master Nov 6, 2023
3 checks passed
@Nicogene Nicogene deleted the fix/soles branch November 6, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misalignment of the l_sole and r_sole frames in ergoCubSN001 and ergoCubGazeboV1_1 models
3 participants