ergoCubV1_1: remove ft sensors of the arms #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
force-pushed
the
ergoCubV1_1RemoveArmsFts
branch
from
d31a358 to
995932f
Compare
Ok for me, if it is ok for @GiulioRomualdi @S-Dafarra @mebbaid |
No problem for me |
traversaro
approved these changes
Dec 21, 2023
|
I think we can merge it as it is, the only think is that on master branch landed this PR: That requires to update gyp to the latest master. If it is ok @GiulioRomualdi and @S-Dafarra I merge it otherwise if it is easier to use this branch please let me know |
Nicogene
force-pushed
the
ergoCubV1_1RemoveArmsFts
branch
from
995932f to
6be5893
Compare
|
I rebased on latest master and I am going to merge it since I think I will soon revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #200
As side effect this PR removes also the nws for ergocub 1.0, the optimal solution would be to have two different xml files (e.g.
ergocub1_0.xml.ergocub1_1.xml.But since this a temporary workaround that will be hopefully soon reverted we could avoid to add yet another xml file to be maintained.
What do you think about @traversaro @GiulioRomualdi @pattacini ?