-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test for model generation #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
added
domain-software
Related to Software
prj-ergocub
Related to ErgoCub Project
team-fix
Related to Team Fix
labels
Jan 9, 2023
This was referenced Jan 9, 2023
Closed
Closed
traversaro
approved these changes
Jan 10, 2023
Ok for me, even if we are mixing conda and apt/pip and this could create problems in the future. |
This PR closes also #24 since the difference in orientation is due to #7 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain-software
Related to Software
prj-ergocub
Related to ErgoCub Project
team-fix
Related to Team Fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the consistency tests for the model generation.
I imported the tests by copying-pasting the tests for icub3
Running the tests I corrected some axis orientations(#7) but some failures in the joint orientation cannot be fixed by simply inverting the axes.
Moreover, we have also discrepancies in the ft sensors orientation and
r/l_sole
alignment, for now I disabled the failing tests in order to not making fail the CI, but I think they have to be addressed in separate issuesIt fixes #6