Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test for model generation #22

Merged
merged 9 commits into from
Jan 10, 2023
Merged

Enable test for model generation #22

merged 9 commits into from
Jan 10, 2023

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Jan 9, 2023

This PR imports the consistency tests for the model generation.
I imported the tests by copying-pasting the tests for icub3

Running the tests I corrected some axis orientations(#7) but some failures in the joint orientation cannot be fixed by simply inverting the axes.

Moreover, we have also discrepancies in the ft sensors orientation and r/l_sole alignment, for now I disabled the failing tests in order to not making fail the CI, but I think they have to be addressed in separate issues

It fixes #6

@Nicogene Nicogene added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Jan 9, 2023
@Nicogene Nicogene requested a review from traversaro January 9, 2023 10:59
@Nicogene Nicogene self-assigned this Jan 9, 2023
@Nicogene Nicogene mentioned this pull request Jan 9, 2023
@traversaro
Copy link
Member

Ok for me, even if we are mixing conda and apt/pip and this could create problems in the future.

@Nicogene
Copy link
Member Author

This PR closes also #24 since the difference in orientation is due to #7 (comment)

@pattacini pattacini linked an issue Jan 10, 2023 that may be closed by this pull request
@Nicogene Nicogene merged commit d495d42 into master Jan 10, 2023
@Nicogene Nicogene deleted the feat/addUnitTest branch January 10, 2023 10:48
@Nicogene Nicogene restored the feat/addUnitTest branch January 11, 2023 15:19
@Nicogene Nicogene deleted the feat/addUnitTest branch January 24, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check orientations of ft sensors in the arms Add unit tests and CI
2 participants