Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alljoints inertials to work also on gz-sim #250

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

xela-95
Copy link
Contributor

@xela-95 xela-95 commented Aug 6, 2024

Fixing regression of #232 concerning the use of ergocub UDRF files on gz-sim through gz-sim-yarp-plugins.

Related issue robotology/gz-sim-yarp-plugins#173
Related PR: #251

CC @traversaro

@xela-95 xela-95 force-pushed the fix/gz-alljoints-inertials branch from 401534a to c6050dc Compare August 6, 2024 16:14
@xela-95
Copy link
Contributor Author

xela-95 commented Aug 6, 2024

I've started to update just the base_1_1.yaml file, so that we can try to generate the new URDF and test that it works. Than I will port the updates to the other models.

@traversaro
Copy link
Member

@xela-95 @Nicogene I temporarly pushed the branch to https://github.com/icub-tech-iit/ergocub-software/tree/fix/gz-alljoints-inertials to be able to generate a URDF in it.

@xela-95
Copy link
Contributor Author

xela-95 commented Aug 7, 2024

Now that the models V1_1 and V1_2 generated in #251 work, I think I need just to manually update the version 0 models for compatibility.

@xela-95 xela-95 marked this pull request as ready for review August 7, 2024 09:31
@Nicogene Nicogene merged commit 9531ed8 into icub-tech-iit:master Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants