Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misalignment between feet soles #27

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

mfussi66
Copy link
Member

This PR aims to fix: #23

The exported material from the CAD is committed.

@mfussi66 mfussi66 requested a review from Nicogene January 12, 2023 12:49
@mfussi66 mfussi66 self-assigned this Jan 12, 2023
@pattacini pattacini added domain-software Related to Software team-fix Related to Team Fix labels Jan 12, 2023
@Nicogene
Copy link
Member

Seems that something went wrong in the generation:

     Start 1: ergoCubGazeboV1ConsistencyCheck
1/2 Test #1: ergoCubGazeboV1ConsistencyCheck ...***Failed    0.02 sec
ergocub-model-test error: r_knee is not revolute 

    Start 2: ergoCubSN000ConsistencyCheck
2/2 Test #2: ergoCubSN000ConsistencyCheck ......***Failed    0.02 sec
ergocub-model-test error: r_knee is not revolute 

@Nicogene
Copy link
Member

Nicogene commented Jan 12, 2023

For some reason r_knee is exported as weld

      <SimpleJoint>
        <name>"SIM_ECUB_R_UPPER_LEG--SIM_ECUB_R_LOWER_LEG"</name>
        <nodeID>"115:-:116"</nodeID>
        <status>""</status>
        <base>
          <JointSide>
            <name>""</name>
            <connection>
              <Frame ref="35"></Frame>
            </connection>
          </JointSide>
        </base>
        <follower>
          <JointSide>
            <name>""</name>
            <connection>
              <Frame ref="36"></Frame>
            </connection>
          </JointSide>
        </follower>
        <primitives>
          <Primitive>
            <name>"weld"</name>
            <nodeID>""</nodeID>
            <referenceFrame>"WORLD"</referenceFrame>
            <axis>0.57735,0.57735,0.57735</axis>
          </Primitive>
        </primitives>
      </SimpleJoint>

cc @salvi-mattia @Mick3Lozzo

@salvi-mattia
Copy link
Member

@Mick3Lozzo
in order to push the simscape button, do we have to open the mech assembly in sandbox/221219_ergoCub_simulation_model_neutral_format

or in project/simulationmodel/ecub ?

@Mick3Lozzo
Copy link
Member

Mick3Lozzo commented Jan 12, 2023

@Mick3Lozzo in order to push the simscape button, do we have to open the mech assembly in sandbox/221219_ergoCub_simulation_model_neutral_format

or in project/simulationmodel/ecub ?

In sandbox/221219_ergoCub_simulation_model_neutral_format @salvi-mattia. These are the Creo 7 compatible files.

@salvi-mattia
Copy link
Member

the right knee seems to be weel defined

@Nicogene
Copy link
Member

Right now I had to manually fix the simmechanics XML for the r_knee exported as weld, and the missing stl for l_wrist_1 link

Shall we keep track in a separate issue of these glitches in the exportation from creo?

@Lawproto @mfussi66 @Mick3Lozzo @pattacini @salvi-mattia @fiorisi

@pattacini
Copy link
Member

Shall we keep track in a separate issue of these glitches in the exportation from creo?

Yep definitely. I'll open a dedicated issue asap.
In the meantime, you can proceed with merging the PR if everything else is fine.

@Nicogene Nicogene merged commit b5a53a7 into icub-tech-iit:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software team-fix Related to Team Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r_sole and l_sole are not centered
5 participants