ergoCubEmotions module - stint 2 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinaxgloria
force-pushed
the
feat/stint2
branch
from
291aaa6 to
a045024
Compare
7 tasks
7 tasks
pattacini
requested changes
Mar 28, 2023
There was a problem hiding this comment.
Fantastic job @martinaxgloria 🚀
I would only refine the documentation. Please, follow the hints I dropped inline.
pattacini
approved these changes
Mar 28, 2023
Nicogene
approved these changes
Mar 29, 2023
|
Merged, thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is now refactored and the images are stored in a context called
ergoCubEmotionsand installed by means ofyarp_install. In this way, ResourceFinder finds and reads the configuration file which is installed in a YARP's installation dir.