Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop proper facial expressions handler – Stint 3 #89

Merged
merged 9 commits into from
Apr 12, 2023

Conversation

martinaxgloria
Copy link
Member

This PR contains the improvements in the ergoCubEmotions module. In particular, the module now contains a service that tells the user which are the available emotions that can be set (it is simply called availableEmotions()), it is integrated in yarpmanager and some tests were done on a NVIDIA Xavier AGX on bench, displaying only static images.
Moreover, the module features the possibility to display videos but some tests have to be done yet.

@martinaxgloria martinaxgloria requested a review from Nicogene April 7, 2023 09:29
@martinaxgloria martinaxgloria self-assigned this Apr 7, 2023
@martinaxgloria martinaxgloria requested review from Nicogene and removed request for Nicogene April 7, 2023 09:29
@martinaxgloria martinaxgloria requested a review from pattacini April 7, 2023 09:46
@Nicogene Nicogene linked an issue Apr 7, 2023 that may be closed by this pull request
6 tasks
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to see how videos will be rendered 😄

src/modules/ergoCubEmotions/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/modules/ergoCubEmotions/ergoCubEmotions.h Show resolved Hide resolved
@martinaxgloria martinaxgloria marked this pull request as ready for review April 12, 2023 10:06
@Nicogene Nicogene merged commit 7aa61e0 into icub-tech-iit:master Apr 12, 2023
@Nicogene
Copy link
Member

Merged, thanks!

@martinaxgloria martinaxgloria deleted the feat/stint3 branch April 12, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop proper facial expressions handler – Stint 3
3 participants