[DEFECT] Iteration limit is not implemented in GradientDescent

[Jimmy-INL]

Thank you for the defect report

• I am using the latest version of RAVEN.
• I have read the Wiki.
• I have created a minimum, reproducible example
  that demonstrates the defect.

Defect Description

Although the is clearly described in the manual to reflect the number of model evaluations not the number of optimizer iterations, the user should have control over selecting the number of optimization steps/iterations.

If the user needs 10 iterations, he/she should be able to get 10 iterations as long as the optimizer did not converge before 10. This is regardless of the number of additional evaluations used to compute the gradients at each step.

Steps to Reproduce

Please just use the basic.xml test under tests/framework/Optimizers/GradientDescent/ and set the limit to 10.

Expected Behavior

To get 10 iterations

Screenshots and Input Files

No response

OS

MacOS

OS Version

No response

Dependency Manager

CONDA

For Change Control Board: Issue Review

• Is it tagged with a type: defect or task?
• Is it tagged with a priority: critical, normal or minor?
• If it will impact requirements or requirements tests, is it tagged with requirements?
• If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
• Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

• If the issue is a defect, is the defect fixed?
• If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
• If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
• If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
• If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

[mandd]

@Jimmy-INL : were you able to get it resolved after last Monday meeting?

[Jimmy-INL]

Not yet, My interns and I will work on it.