Add normalizer type C to text cleaners #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eginhard
requested changes
Sep 29, 2024
There was a problem hiding this comment.
Thank you for the PR and tests, it looks good! I suggest to rename the function to make the name more intuitive. I'd call it at the start of every cleaner, except no_cleaners().
You can run make clean && make lint to make sure your code passes the style check.
TTS/tts/utils/text/cleaners.py
Outdated
Comment on lines
192
to
193
| def normalize_nfc(text: str) -> str: | ||
| """Canonical decomposition followed by canonical composition""" |
There was a problem hiding this comment.
Suggested change
| def normalize_nfc(text: str) -> str: | |
| """Canonical decomposition followed by canonical composition""" | |
| def normalize_unicode(text: str) -> str: | |
| """Normalize Unicode characters.""" |
shavit
force-pushed
the
63-normalize
branch
from
5412923 to
636ea59
Compare
shavit
commented
Sep 30, 2024
shavit
force-pushed
the
63-normalize
branch
from
1576006 to
8ec5d15
Compare
eginhard
approved these changes
Oct 2, 2024
eginhard
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Add normalizer type C to text cleaners * Linter recommendations * Add unicode normalize to every cleaner * Format test_text_cleaners.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are duplications in the cleaners, should the normalizer be added inside the other cleaners, or be applied to all text?
https://github.com/idiap/coqui-ai-TTS/blob/dev/TTS/tts/utils/text/tokenizer.py#L110
/Closes #63