Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Node v15 #694

Closed
mathisonian opened this issue Feb 12, 2021 · 5 comments · Fixed by #719 or #724
Closed

Issues with Node v15 #694

mathisonian opened this issue Feb 12, 2021 · 5 comments · Fixed by #719 or #724

Comments

@mathisonian
Copy link
Member

Describe the bug
It appears that there may be some incompatibilities with node v15. See #680 and #693.

I'll keep this issue open to track until we've confirmed a fix. For now the recommended solution is to use https://github.com/nvm-sh/nvm to install another version (e.g. v14) and use idyll with that version.

@rogerfitz
Copy link
Member

I took a stab at this last night but how do I go about testing npm install idyll would work with the branch I'm working on? I got it passing tests with node 15 by upgrading the react-tooltip library. Related issue here npm/cli#1734, npm install --legacy-peer-deps .. should work too but the dependency issue was patched in react-tooltip 4.0.1. Creating PR showing what I did here #706

@mathisonian
Copy link
Member Author

If you can run lerna clean && lerna bootstrap in the root of the project with node15 then it should be okay on the dependency side. However I noticed that there is also an issue creating new projects: running idyll create always says that installing dependencies failed, even when it didn't.

A little setup required to test the global command line commands with the local dev version of idyll:

  • make a new folder
  • run npm init to create a package json
  • inside the new package.json add scripts: { "create-idyll-project": "idyll create" }
  • inside that folder run yarn link idyll so that the local copy of idyll is available
  • run yarn run create-idyll-project to run the idyll create command with the dev version

@rogerfitz
Copy link
Member

rogerfitz commented Mar 6, 2021

FYI #707 is main PR now

Thanks for these instructions. I was able to get it running but found an issue with yargs and the commandlineArgs library I introduced in idyll-cli. It was saying command "create" not found . Interestingly when I installed idyll 5.3.4 idyll create was fine but maybe this is just a yarn link thing?

I added a commit fixing that onto #707 since it was pretty small but would you rather I isolate out the commit to something linked to the issue and another branch/PR 386e9cf? Wasn't sure how detailed you like to be about those sorts of things

@rogerfitz rogerfitz mentioned this issue Mar 6, 2021
2 tasks
@mathisonian
Copy link
Member Author

Thanks @rogerfitz! I merged in #707 to get that idyll create fix in. In general the smaller / more tightly scoped a PR is the quicker I'll be able to review and merge but I am flexible and happy to have fixes submitted in any form.

@mathisonian
Copy link
Member Author

I'm reopening because of reports that this hasn't been completely resolved. See #723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants