Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the component dependencies and re test? #790

Open
jimidle opened this issue Jul 12, 2022 · 2 comments
Open

Update the component dependencies and re test? #790

jimidle opened this issue Jul 12, 2022 · 2 comments

Comments

@jimidle
Copy link

jimidle commented Jul 12, 2022

Is your feature request related to a problem? Please describe.
While tackling a few issues in this list, I realize that the various components have a few dependencies that might be worth updating:

  1. The projects seem to be a little out of sync in that they are using slightly different versions in some cases - that could be me misreading things though.
  2. Some dependencies are many major versions behind - but perhaps they are not used by Idyll [everytime I type this I feel like I am misspelling my own name].
  3. The version of React is not up to date - perhaps this is on purpose?

Describe the solution you'd like
I wonder if it is worth me going through all the components and gradually upgrading the dependencies, then retesting. The project should then be up to date, assuming that there are no breaking changes.

Describe alternatives you've considered
That I don't know what I am talking about! ;)

@mathisonian
Copy link
Member

I think this would be good to do. There are some idyll-cli test repos that I know use quite out of data libraries. I think it would make sense to modernize these as well, although it will require some work to update the expected output for the tests. I can help with that.

With React I think we can upgrade to the latest although there may be some places where components depend on react lifecycle methods that need to be updated. Depending on the amount of changes required it may make sense to scope this to its own PR.

I've invited you become a member of the idyll org so that you can work on this via a branch on this repo and its easier for me to push tweaks to the PR.

[everytime I type this I feel like I am misspelling my own name].

lol

@jimidle
Copy link
Author

jimidle commented Jul 16, 2022

OK Matthew - I will take a stab at this. As you are clearly aware, sometimes it is not see easy to upgrade "everything" - so I will try to do this in smaller steps than one huge PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants