Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tool only keeps one version of a review document but gives the impression that it keeps all of them. #6941

Open
rjsparks opened this issue Jan 19, 2024 · 1 comment
Labels

Comments

@rjsparks
Copy link
Member

The review tool maintains only a single image of the review document, kept on disk with no version number. "Revising" the review overwrites that single image, but tell the related Document object that a new version has been created. The views of that object then show the same bits for all versions, leading to confusion.

There's no way to reconstitute earlier versions of the reviews to date. We should either change the UI to note that the review document is mutable (as it currently is on disk) or change the storage to match every other document type and actually keep versions.

@rjsparks
Copy link
Member Author

change the storage to match every other document type and actually keep versions.

is what the code was originally intended to do and is what the reviewers and consumers of the review expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant