Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert endpoint may not take the correct mime type into consideration #324

Open
tagliala opened this issue Oct 9, 2024 · 0 comments
Open

Comments

@tagliala
Copy link
Member

tagliala commented Oct 9, 2024

  • The second parameter
    content = Converter.new(logger: @logger).convert_file(params[:action], body, params[:language])
    is not a file, but the file content, which is a string.
  • If the string is plain text, the convert method might miss that it is actually text/markdown and not necessarily text/plain.
  • The params[:file][:type] is indeed correct.

Reference: Issue #322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant