fix!: corrected broken lockfile #339
Merged
+1,331
−698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected broken lockfile after a merge conflict. BREAKING CHANGE: previous pr made an api change
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
What's the breaking change here? This refers to a previous PR in some way, but there's no link to which PR and it's not clear... does this revert back to the original behaviour, undoing the previous PR? What had changed there? What action is needed now, if any, and in which circumstances? |
|
Hi @bmulholland. There was an api change in a previous pr that incorrectly missed to be specified as a breaking change . Therefore to fix the error this pr was instead pushed as a braking change. Sorry for not making that clearer. |
|
@iFaxity got it -- thank you! Which PR was that? |
|
@bmulholland This one #212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected broken lockfile after a merge conflict.
BREAKING CHANGE: previous pr made an api change