Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for NAT, resolved #69 #264

Closed
wants to merge 1 commit into from
Closed

Added support for NAT, resolved #69 #264

wants to merge 1 commit into from

Conversation

inbangsa
Copy link
Collaborator

This resolves issue #69

  • now user can inject port number for communication to device, this can be useful for devices which are behind NAT router

@inbangsa inbangsa linked an issue Sep 21, 2020 that may be closed by this pull request
Running a O3D/O3X behind a NAT router #69
Closed
graugans
graugans requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@graugans graugans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo mentioned in my comment.

modules/swupdater/include/ifm3d/swupdater/swupdater.h
@@ -34,9 +38,13 @@ namespace ifm3d
* @param cam Camera object to manipulate
*
* @param cb Opitonal user-defined callback to handle status updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the line above Opitonal -> optional

@graugans
Copy link
Member

I am also interested in a test by @GreNait which can be performed with the binaries generated here: https://github.com/ifm/ifm3d/actions/runs/264972185

To test the framegrabber module the usage of the Hz command should be sufficient ifm3d hz

@inbangsa inbangsa closed this Jan 29, 2021
@inbangsa
Copy link
Collaborator Author

this feature is already merged to master

ifm-csr pushed a commit that referenced this pull request Jan 9, 2024
Merge branch '264-cmake_download_websocketpp_module' into 'main'
4a7e56c 
Download websocketpp  at compile time & fix for bug #434 from github

Closes #264

See merge request syntron/support/csr/ifm3d/ifm3d!350
BigBoot pushed a commit that referenced this pull request Oct 25, 2024
Merge branch '264-cmake_download_websocketpp_module' into 'main'
d7f40d0 
Download websocketpp  at compile time & fix for bug #434 from github

Closes #264

See merge request syntron/support/csr/ifm3d/ifm3d!350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graugans graugans graugans requested changes

Assignees

@graugans graugans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running a O3D/O3X behind a NAT router
2 participants
@inbangsa @graugans