Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go.mod for use with vgo #61

Closed
igm opened this issue May 29, 2018 · 2 comments
Closed

add go.mod for use with vgo #61

igm opened this issue May 29, 2018 · 2 comments
Assignees

Comments

@igm
Copy link
Owner

igm commented May 29, 2018

As vgo became accepted proposal let's add go.mod. Especially for v2, so that import path can be in the form vgo understands, ie;
import "github.com/igm/sockjs-go/v2/sockjs"

@igm igm self-assigned this Mar 29, 2020
@igm
Copy link
Owner Author

igm commented Mar 29, 2020

The steps:

  • create a PR with/ v2 and subdirectory in the root tree with the content of branch v2 with adding support for go modules and merge into master
  • after the PR merge tag the master with v2.0.2
  • create a PR for branch v2 with go modules support by adding go.mod file with module gopkg.in/igm/sockjs-go.v2 and tag branch with a new tag v2.1.0
  • create a PR for master with / v3 subdirectory in the root with the content of current master which is a current dev version and soon will be released as v3

@igm igm linked a pull request Apr 1, 2020 that will close this issue
@igm igm removed a link to a pull request Apr 1, 2020
@igm
Copy link
Owner Author

igm commented Apr 26, 2020

fixed in v2 and v3

@igm igm closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant