Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: Add an option to generate types without tests #1146

Open
dshulyak opened this issue May 18, 2021 · 3 comments
Open

UPDATE: Add an option to generate types without tests #1146

dshulyak opened this issue May 18, 2021 · 3 comments
Labels
type:enh Improvement or update to existing feature(s). type:testing
Milestone

Comments

@dshulyak
Copy link
Contributor

dshulyak commented May 18, 2021

As suggested in #1137 (review) we should be able to generate types without tests.

@aljo242
Copy link
Contributor

aljo242 commented Oct 27, 2022

@ilgooz @fadeev @lubtd do we still think this would be useful? Personally, I do not find this useful. Our tool should be funneling people towards best practices.

@lumtis
Copy link
Contributor

lumtis commented Oct 27, 2022

I would say Ignite should behave under the best practice by default but we still give the option to make the scaffolding as minimal as possible.
For the basic keeper methods to interact with the type, the tests are straightforward but some commands like for for the tests for message the scaffolded tests might have a structure the user doesn't want to use, if they already have a custom test suite framework for example

@aljo242 aljo242 added component:scaffold Feature, enhancement, or refactor related to scaffolding. pr:need-review Change request requires peer review. and removed pr:need-review Change request requires peer review. labels Nov 1, 2022
@salmad3 salmad3 moved this to Backlog in Ignite CLI Masterboard Feb 7, 2024
@salmad3
Copy link
Member

salmad3 commented Feb 14, 2024

Recently added an option to scaffold a minimal chain (#3835). We can work off this to include an option to exclude tests when generating types.

@salmad3 salmad3 moved this from Backlog to Todo in Ignite CLI Masterboard Feb 14, 2024
@salmad3 salmad3 added this to the v30 milestone May 30, 2024
@salmad3 salmad3 added type:new To implement new feature. type:testing and removed component:scaffold Feature, enhancement, or refactor related to scaffolding. labels May 30, 2024
@salmad3 salmad3 changed the title Add an option to generate types without tests UPDATE: Add an option to generate types without tests Jan 23, 2025
@salmad3 salmad3 added type:enh Improvement or update to existing feature(s). and removed type:new To implement new feature. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enh Improvement or update to existing feature(s). type:testing
Projects
Status: Todo
Development

No branches or pull requests

4 participants