-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: eliminate manual edits from autogenerated files #1207
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Update: Second commit eliminates the last remaining manual edit. I'm not even sure if this was a manual edit, or the result of a C-side bugfix in the interface definition. |
53a7505
to
405d633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the drift! Please add the "mergequeue" label when good.
if (igraph_opt("add.vertex.names") && is_named(graph)) { | ||
names(res) <- vertex_attr(graph, "name", V(graph)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit of code was incorrect, so I intentionally allowed it to be removed by the auto-generation. This code was trying to add vertex names to a vector that contains edge-quantities, not vertex quantities. I also removed a dependence of the result on V(g)
in functions-R.yaml
for the same reason, although this seemed to have no ill effect.
If you find anything else that looks suspicious, let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: As far as I can tell, we're not exposing this function at the moment, so this bug did not have any consequences so far.
as the result is associated with edges and not vertices. Also fix invalid dependency specification: no dependency on V(g).
405d633
to
32ef7b3
Compare
@krlmlr Can we please have this merged now to reduce the pain of having to untangle manual edits to autogenerated files whenever re-running stimulus?
Issues opened:
void
for empty argument lists in C stimulus#6Explanation of changes:
is_bipartite
andrealize_bipartite_degree_sequence
are new in 0.10.9, hence added due to the C core updatehas_attribute_table
andigraph_version
were edited to fix a compiler warning, but we don't actually use them, so removed; issue opened in stimulusget_subisomorphisms_vf2_callback
: the generated R code for this was manually removed, and it's simpler to also remove the generated C code until we actually need it.Ref: #1176