Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix use of deprecated functions in examples #827

Merged
merged 5 commits into from
May 30, 2023

Conversation

maelle
Copy link
Contributor

@maelle maelle commented May 29, 2023

Fix #825

@szhorvat This was semi-automatic: I automatically found calls to deprecated functions (only those from R7zzz-deprecate.R though) then replaced them manually.

@krlmlr Should this script stay in the package?

@maelle maelle requested review from szhorvat and krlmlr May 29, 2023 14:10
@maelle maelle marked this pull request as draft May 29, 2023 14:23
@maelle
Copy link
Contributor Author

maelle commented May 29, 2023

The test failure actually appears on main too. 🤔

@szhorvat
Copy link
Member

szhorvat commented May 29, 2023

Very nice that this could be partly automated!

I didn't realise that we marked neighborhood() as a deprecated alias of ego(). "Ego" is a very social science centric description of the concept and IMO should not be the default name in a general purpose network analysis package. Perhaps it would be better to keep both names as non-deprecated? What do you think @ntamas ?

For this PR, let's keep neighborhood() as is (not replace by ego()) and merge.

R/scan.R Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just revert this single modification and then merge

@maelle maelle mentioned this pull request May 30, 2023
@maelle maelle marked this pull request as ready for review May 30, 2023 07:30
@maelle maelle merged commit 6483abe into igraph:main May 30, 2023
@maelle maelle deleted the examples branch May 30, 2023 07:30
@ntamas
Copy link
Member

ntamas commented May 30, 2023

What do you think @ntamas ?

This was a decision made by Gábor a long time ago and I kinda disagree with it. I'd un-deprecate neighborhood() but keep ego() as a permanent alias.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that no deprecated functions are used in examples
3 participants