Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error on windows with feature "win32" enabled #37

Closed
DaTa- opened this issue Mar 22, 2018 · 3 comments
Closed

Compile error on windows with feature "win32" enabled #37

DaTa- opened this issue Mar 22, 2018 · 3 comments
Assignees

Comments

@DaTa-
Copy link

DaTa- commented Mar 22, 2018

This line fails to compile (warn! macro is missing)

warn!("Decoding input as UTF-16 failed. The two values that could not be decoded were {} and {}.", first_error.unpaired_surrogate(), second_error.unpaired_surrogate());

duo to incorrect cfg condition
#[cfg(any(feature = "win32a", all(not(feature = "win32"), not(feature = "win32a"))))]

@ihalila ihalila self-assigned this Mar 25, 2018
@ihalila
Copy link
Owner

ihalila commented Mar 26, 2018

Fixed the error in a9122a5, there's some test failures I'll take a look at but it should work.

@ihalila
Copy link
Owner

ihalila commented Mar 31, 2018

The only tests that fail are some doctests that try to initialize the screen, I assume this is related to the running environment not being suitable for the win32 flavor. I'm gonna let that pass since for actual applications it works just fine.

@ihalila ihalila closed this as completed Mar 31, 2018
@nickolay
Copy link

The only tests that fail are some doctests that try to initialize the screen

I stumbled on this while trying to figure out if there are known problems with the KeyResize event on win32. While I didn't find the reason KeyResize wasn't working, I found two issues that together probably cause the doctests to fail on win32:

For completeness, the error message is:

LINES value must be >= 2 and <= 600: got -20132
initscr(): Unable to create SP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants