-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOCKS proxy support #191
Comments
Looks straightforward enough, just a matter of giving the option to pass the proxies on run, something like: This does pull in optional dependencies that 95% of users likely won't need so I have to figure out if I want to add it as a hard requirement by pulling requests[socks] in or add the option when installing bandcamp-dl itself. (IE It will be in the next release, of that you can be sure. |
requests, the network library bandcamp-dl uses, supports SOCKS with required dependencies installed by |
Yep, I was aware it was supported but not that just setting a few environment variables was all that was needed for setup. May be better if sooner rather than later bandcamp-dl gets config file support. |
Access to the Bandcamp website is banned in my country(Yes, I live in such a hell). Therefore the Bandcamp-dl cannot do anything and just waits until the whole process is timed out. The same thing happens to the youtube-dl, but youtube-dl supports SOCKS proxies, and I can give it the proxies that I have as an option to the command.
It will be beneficial if Bandcamp-dl adds the support for proxies too.
The text was updated successfully, but these errors were encountered: