Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): refactor the db layer to improve its extensibility #181

Merged
merged 4 commits into from
Oct 11, 2022
Merged

fix(db): refactor the db layer to improve its extensibility #181

merged 4 commits into from
Oct 11, 2022

Conversation

ihexxa
Copy link
Owner

@ihexxa ihexxa commented Oct 10, 2022

Please answer following questions before creating the PR:

  • What is this PR about?
    • add id as the pk for some tables
    • make base store as the underlying layer of sqlite store
  • Is there any test which covers the change?
    • unit tests
    • e2e tests

@ihexxa ihexxa self-assigned this Oct 10, 2022
@ihexxa ihexxa temporarily deployed to Staging October 10, 2022 13:20 Inactive
@ihexxa ihexxa merged commit dd3ef8f into main Oct 11, 2022
@ihexxa ihexxa deleted the fix-db-defects branch October 11, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ihexxa