Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat screen, Ballista info window, take into account the captain/hero's attack for the displayed attack value of archers #8807

Open
1 task done
LeHerosInconnu opened this issue Jun 4, 2024 · 0 comments
Labels
improvement New feature, request or improvement

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Describe the problem requiring a solution

In fheroes2, the attack value of the captain/hero is not added to the attack value of the archers in the ballista information window.
In the original game, this is not the case either.
I suggest that this be taken into account to display a value that really corresponds to the attack value.

In original game: (click to expand)

No mage guild built:
Ballista info window 001

First mage guild level built:
Ballista info window 002

Captain's quarters built, captain has 1 attack:
Ballista info window 003

Hero leads defense, hero has 3 attack:
Ballista info window 004

In fheroes2: (click to expand)

No mage guild built:
Ballista info window 005

First mage guild level built:
Ballista info window 006

Captain's quarters built, captain has 1 attack:
Ballista info window 007

The text should display an attack bonus of 1 + 1 = 2.
Ballista info window 008

Hero leads defense, hero has 3 attack:
Ballista info window 009

The text should display an attack bonus of 1 + 3 = 4.
Ballista info window 010

Here is the test scenario file:
0 9905.zip

Describe the possible solution

Display the value that really corresponds to the attack value.

It should be:

In the example, with the captain:
"The Ballista fires... ...with a +2 bonus to their attack skill."
"The Left Turret fires... ...with a +2 bonus to their attack skill."
"The Right Turret fires... ...with a +2 bonus to their attack skill."
Note that the captain has a different attack value depending on the type of castle.

In the example with the hero:
"The Ballista fires... ...with a +4 bonus to their attack skill."
"The Left Turret fires... ...with a +4 bonus to their attack skill."
"The Right Turret fires... ...with a +4 bonus to their attack skill."

Additional info

No response

@LeHerosInconnu LeHerosInconnu added the improvement New feature, request or improvement label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

No branches or pull requests

1 participant