Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scenario Editor] Hero's default troop graphics should be displayed with the possible range for the number of creatures #8920

Open
2 tasks done
LeHerosInconnu opened this issue Jul 6, 2024 · 5 comments
Labels
editor Map editor related stuff improvement New feature, request or improvement ui UI/GUI related stuff
Milestone

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Platform

Windows

Describe the bug

In fheroes2, the hero's default troop graphics should be displayed with the possible range for the number of creatures, e.g. "8-12", "0-4", in each default troop slot.

In fheroes2:

Select standard scenarios 005

Save file

Not needed.

Additional info

No response

@LeHerosInconnu LeHerosInconnu added the bug Something doesn't work label Jul 6, 2024
@zenseii zenseii added improvement New feature, request or improvement ui UI/GUI related stuff editor Map editor related stuff and removed bug Something doesn't work labels Jul 7, 2024
@zenseii
Copy link
Collaborator

zenseii commented Jul 7, 2024

@LeHerosInconnu. I consider this a request for improvement rather than a bug. Iirc the original editor didn't supply such information either.

@zenseii zenseii added this to the 1.1.2 milestone Jul 7, 2024
@LeHerosInconnu
Copy link
Author

LeHerosInconnu commented Jul 8, 2024

@zenseii,

@LeHerosInconnu. I consider this a request for improvement rather than a bug. Iirc the original editor didn't supply such information either.

I'd thought of putting it as an "improvement", but as I'd put "bug" for the hero's default secondary skills display issue, I wanted to stay consistent. :)
And I feel it's more of a bug than an improvement in the way it's presented in the fheroes2's scenario editor.

In the original game's scenario editor, the user takes the step of interacting with the interface to access the possibility of changing the hero's default troops.

In fheroes2's scenario editor, even if the user doesn't wish to modify the hero's troops, the interface that allows him to do so is displayed directly.
How can he know what's going to happen?
The user may be confused as there are no default troops displayed.
"Will the hero have no troops in the scenario, if I don't add creatures in this screen?"
"Which creatures will be present in the hero's army?"
"How many?"

Even the number of the hero's experience points should be displayed in this screen.
I'll open an issue for this later (#9007).

@Mr-Bajs
Copy link
Contributor

Mr-Bajs commented Jul 8, 2024

I find having a title for each single slot rather ugly, redundant and clutterd.

Shouldn't just large single description title over each category suffice? Would look cleaner. Something similar to this.
deffproto

@LeHerosInconnu
Copy link
Author

Hello @Mr-Bajs and @zenseii,

I find having a title for each single slot rather ugly, redundant and clutterd.

Personally, I wouldn't mind simply deleting all the "Default value", "Default troop" and "Default skill" texts in this screen. :)

@Mr-Bajs
Copy link
Contributor

Mr-Bajs commented Jul 28, 2024

Yes. Just an dark shade would suffice. Same as castle and towns when using default values.

@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

No branches or pull requests

4 participants