-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-executability - notes from my journey #23
Comments
Thanks @consideRatio for the feedback - it's great to see that the assessment notebooks are being used! General responseThe notebooks and the repository, as well as the This repository wasn't intended to be executed as is, hence the missing environment files. I've no experience with my https://binder.org, so I'm not sure if this is worth the effort - I have basically done a poor man's version of that by posting the executed notebooks here. But I would really appreciate any PR fro you to improve the user experience. Maybe just adding to the README would already be a big help for the next user... Detailed responsesFolder structureThe file If you run the categorisation-notebook first, all notebooks should run fine (a related issue about the plotting-settings was raised by @nworbmot in #15). Why do we make you download the data?See the section Why did we choose this license? section at the IAMC 1.5°C Scenario Explorer License page why we thought it was important to keep track of users (TL;DR: to send announcements when we fix data errors so that users can update their analysis accordingly). Having said that, The main dependency: the
|
Not closing this issue for now, hoping for a PR from you, @consideRatio... Please close this issue if you feel you won't have time for it. |
So i have just gone through and re-created this project on my own laptop, and after quite a lot of debugging, got it all working. i am on an m1 mac, and had to use rosetta for an intel environment so i could install python 3.7 as well as some of the older packages. there were a couple errors in the notebook for generating the .yaml file (which you have corrected on the web version, but not pushed to master). I also had remove a line from the .yaml file that was causing a constructor error, but with that removed. I was able to reproduce everything, and am now playing about with it myself. i'm looking into mybinder/docker or at the very least producing a some requirements files for a working version. |
just to follow up here. my working branch is here https://github.com/whatfuturedotlol/ipcc_sr15_scenario_analysis/tree/iam-update it includes
I couldn't get a mybinder.org version working as it ran out of memory with error 137. I may look at this later, but for now this branch provides the relevant fixes to get it working. |
I'm very excited that this is available on GitHub! Thank you everybody involved in this!
I'd love to help out making it runnable by the click of a badge on mybinder.org. Like this one, allowing you to re-execute some data analysis part of the LIGO teams work to analyze the gravitational wave sensor data.
https://mybinder.org/v2/gh/minrk/ligo-binder/master?urlpath=lab/tree/index.ipynb
Below are my notes on trying to run the notebooks without any previous experience of this work.
Notes
In short, mybinder.org will given a given github repo build a docker image and install dependencies found in typical configuration files like conda's environment.yml etc. As far as I can tell though, this repo does not yet contain any information on its python package dependencies other than perhaps information about
pyam
that should be of version0.2.0
.So, I set out to try to figure out what made the code runnable, create an environment.yml file, and add a mybinder.org badge to the README.md in a PR.
But, I run into some issues though.
pyam=0.2.0
pandas=0.24
andipython
I started out cloning the repo, created a fresh conda environment with Python 3.7, and installed pandas and pyam. That led me to the following error when importing pyam though.
Apparently that issue was resolved with
pandas=0.24
instead ofpandas=0.25
. And another issue went away by installingipython
.Downloading of data
Minor renaming of metadata file imports
I needed to adjust the import of the metadata.
Notebook execution success
After the above, no errors occurred running
spm_sr15_figure_3a_global_emissions_pathways.ipynb
and all files down to the one withsr15_2.4.1
in its name.Summary of impressions
/data
folder, then the manual steps could be reduced significantly. Perhaps that is actually already possible without me knowing about it? Hmmm...The text was updated successfully, but these errors were encountered: